Hi,

When I upgraded the site from D10.2 to D10.3, I found there was a missing style for a spinning icon at the end of the text field.

I noticed that on Drupal 10.3, the system base library removed some stylings for autocomplete-loading component.
On 10.2, Drupal loads the CSS file css/components/autocomplete-loading.module.css, but this file is removed from loading on 10.3
https://git.drupalcode.org/project/drupal/-/blob/10.2.x/core/modules/sys...
https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/modules/sys...

So I think toolshed autocomplete library should add core/drupal.autocomplete as a dependency.

Thanks!

CommentFileSizeAuthor
toolshed-add-drupal-autocomplete-library-to-toolshed-autocomplete-library.patch331 bytessea2709

Issue fork toolshed-3466654

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sea2709 created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !10

sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review

Hi ,
I have created MR!10 for the above issue, Please review it once.

Thanks!.

lemming’s picture

lemming commented
Assigned: Unassigned » lemming
Status: Needs review » Fixed

I've added styles for applying the default autocomplete styling starting with release Beta14

The update was made to this CSS file and is based on Claro from Drupal 10.3 & Drupal 11.
Autocomplete.css

Previously Drupal had this styling for the autocomplete element separate from the autocomplete functionality they provided. The change from Drupal core, moves the styling with the autocomplete library, which include the JQuery UI and all the Javascript files, which make sense for Drupal core, but is applying too many dependencies that the toolshed autocomplete doesn't need.

The default styling is very simple and provides a default. Themes, like Claro, are able to override the styling. I've also updated the JS to be compatible with Claro styling (this commit).

Thanks for reporting this issue and helping to find a resolution.

lemming’s picture

lemming commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lemming closed merge request !10