Problem/Motivation

I tried using auto retina module with Drupal 10.3 and got the following error:

PHP Fatal error: Declaration of Drupal\auto_retina\Controller\RetinaImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) in web/modules/contrib/auto_retina/src/Controller/RetinaImageStyleDownloadController.php on line 68

Here is a related Drupal core change record: ImageStyleDownloadController::deliver() now takes a string of the expected scheme for derivatives as a required parameter

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork auto_retina-3466556

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vaish created an issue. See original summary.

amanbtr72 made their first commit to this issue’s fork.

amanbtr72 opened merge request !4

amanbtr72’s picture

amanbtr72 commented
Status: Active » Needs review

Kindly review MR !2

Thanks

vaish’s picture

vaish commented

Thanks for the patch, @amanbtr72. Did you verify if your patch still works with Drupal 10.2?

amanbtr72’s picture

amanbtr72 commented

@vaish I have tested and made a small change and pushed to the same MR, now it's working with 10.2 also.

Kindly review.

Thanks

aklump’s picture

aklump commented
Assigned: Unassigned » aklump
Status: Needs review » Fixed

Thank you @vaish and @amanbtr72 for solving this issue.

aklump’s picture

aklump commented
Status: Fixed » Closed (fixed)