Schema API: 'length' should be ignored on non varchar and char fields

If a module includes a $spec['length'] in its field schema then that length is simply added on to the end field type in _db_create_field_sql, which is a problem in postgres when that field type isn't varchar or character (there are other types where this syntax is allowed but drupal does not use them: see http://www.postgresql.org/docs/7.4/interactive/datatype.html).

A simple fix would be something like
if (!empty($spec['length'])) {
- $sql .= '('. $spec['length'] .')';
+ if(in_array($spec['pgsql_type'], array('varchar', 'character'))){
+ $sql .= '('. $spec['length'] .')';
+ }
}

but obviously it would be better to look at the length supplied and process it according to the type, eg an int of size 8 becomes bigint. However, the above fix at least allows modules like the computed field module to work with postgres, even if they length parameter will sometimes be ignored.

Thanks,
Steven H. Noble