Hello, I am working on replicating the dialogue box for the Accordion Options for version 3.0. Could use some help with this javascript if anyone is available.

CommentFileSizeAuthor
#18 accordion_patch_3463627.patch54.64 KBelectrokate
#17 accordion_dialog_box_3463627.patch0 byteselectrokate

Issue fork uswds_ckeditor_integration-3463627

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

electrokate created an issue. See original summary.

electrokate opened merge request !78

smustgrave’s picture

smustgrave commented

This suppose to be in review?

smustgrave’s picture

smustgrave commented

Just fyi for when this gets put up for review all checks need to pass

Phpstsn next major is known issue so can ignore that one

electrokate’s picture

electrokate commented

Ok thanks, I'm still working on the collapsed checkbox feature.

smustgrave’s picture

smustgrave commented

Sounds like a good feature.

smustgrave’s picture

smustgrave commented
Version: 3.0.x-dev » 3.1.x-dev

smustgrave changed the visibility of the branch add-accordion-options to hidden.

smustgrave changed the visibility of the branch add-accordion-options-squash to hidden.

smustgrave changed the visibility of the branch 3463627-porting-accordion-options to hidden.

smustgrave opened merge request !85

smustgrave closed merge request !78

smustgrave’s picture

smustgrave commented
Status: Active » Needs work

Rebased but the there a ton of out of scope changes in the plugin js that should be reverted as it also breaks accordions.

smustgrave’s picture

smustgrave commented

So I think we can go about this a different route. Instead of through the text formatter lets add 2 new commands to accordion. This way the editors have the power

electrokate’s picture

electrokate commented

Hey smustgrave! Thank you so much for rebasing and trying to get this merged. What can I do to help? I am hoping to get it merged so we don't have to add as a patch going forward.

Does this need to be done to merge?
"Instead of through the text formatter lets add 2 new commands to accordion. "

If so can you elaborate?

smustgrave’s picture

smustgrave commented

Ideally these settings would be attached to the ckeditor plugin so editors can attach per accordion group.

Problem with the text formatter approach is it applies everywhere. So if you don't want certain settings you're stuck.

electrokate’s picture

electrokate commented
StatusFileSize
new accordion_dialog_box_3463627.patch0 bytes

Ok thank you. In the meantime, here is a patch with your rebase from 85.diff, which cleanly applies to 3.1.3, in case anyone needs it. (the 85.diff was not applying for me, I just re-compiled the /build/uswds_accordion.js)

electrokate’s picture

electrokate commented
StatusFileSize
new accordion_patch_3463627.patch54.64 KB

sorry, the last one was blank.

electrokate’s picture

electrokate commented

@smustgrave, just for clarity, currently (in this patched version), there are global settings, which can be set one way or another (in the text editor interface), and then those can be overridden in each accordion that is added in the WYSIWYG, through the use of the dialog box.

smustgrave’s picture

smustgrave commented

In a perfect world we could apply these to individual accordions but know I set the precedent with the global settings. So it's fine to continue on that path vs chasing perfect solution. As we would have to change that other stuff too.

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.