Overview

Postponed on #3462441: Contextual form values need to be integrated with Redux: start with single-property field types
When the props form is changed, the layout updates to reflect those changes. When undo is applied, the layout rolls back, but the props form doesn't. In this issue, lets sync that up.

Proposed resolution

User interface changes

See the screencast on the MR: https://git.drupalcode.org/project/experience_builder/-/merge_requests/180

Issue fork experience_builder-3463618

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Include props form in undo » [PP-1] Include component props form in undo
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
Related issues: +#3462441: Contextual form values need to be integrated with Redux: start with single-property field types
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Include component props form in undo » Include component props form in undo
Status: Postponed » Active

#3462441: Contextual form values need to be integrated with Redux: start with single-property field types is in! 🥳

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: bnjmnm » balintbrews

I'm picking this up as the continuation of #3468050: Values in props edit form do not always match the selected component.

balintbrews opened merge request !180

balintbrews credited jessebaker.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Include component props form in undo » [PP-1] Include component props form in undo
Assigned: balintbrews » bnjmnm
Status: Needs review » Reviewed & tested by the community

@balintbrews indicated this should land after #3468050: Values in props edit form do not always match the selected component, so conveying that.

But it's also down to final review, and this area is definitely @bnjmnm's area of expertise (he introduced #3462441: Contextual form values need to be integrated with Redux: start with single-property field types), so let's get his final sign-off.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

As @bnjmnm pointed out, we need some tests here which I completely forgot about. 🤦🏻 I'll work on those later today.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Include component props form in undo » Include component props form in undo
Assigned: bnjmnm » balintbrews

#3468050: Values in props edit form do not always match the selected component is in.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: balintbrews » bnjmnm
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » Unassigned
Status: Needs review » Reviewed & tested by the community

This seems good to go though if possible I recommend waiting on #3463307: Implement simplified zoom interface to land then refactoring this a bit as the other way around might be more difficult and possibly require an additional issue.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Title: Include component props form in undo » [PP-1] Include component props form in undo

Waiting for #3463307: Implement simplified zoom interface to land as @bnjmnm suggested, then we can have an even cleaner end-to-end test.

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: [PP-1] Include component props form in undo » Include component props form in undo
Issue tags: -Needs tests
balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.