Problem/Motivation

CustomWidgetOrderProcessor extends ProcessorPluginBase which uses the UncacheableDependencyTrait trait.
So using this processor on a facet makes the facet uncacheable.
However there is no reason the result of this processor could not be cached (it only changes when the facet config changes).

Steps to reproduce

Enable Sort by custom order on a facet.
Save the view display using this facet again : the view display now has this config:

    cache_metadata:
      max-age: 0

Proposed resolution

The processor should use the UnchangingCacheableDependencyTrait trait.

Issue fork facets_custom_order-3463587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff changed the visibility of the branch 3463587- to hidden.

prudloff changed the visibility of the branch 3463587- to active.

prudloff opened merge request !1

prudloff’s picture

prudloff commented
Status: Active » Needs review

For some reason, the 1.0.x branch does not contain anything, so the merge request includes the whole module code.

  • ddfced1d committed on 1.0.x 
    git commit -m 'Issue #3463587 by prudloff: custom_widget_order disables...
uniquename’s picture

uniquename commented

I've update the 1.0.x branch and comited the changes.

uniquename’s picture

uniquename commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

prudloff closed merge request !1