Problem/Motivation

All performance test methods are skipped in https://git.drupalcode.org/project/drupal/-/jobs/2215321 since #3421202: Enable W3C-compliant webdriver testing.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3463534

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Yeah this is the arguments... let's fix it.

alexpott opened merge request !8911

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Hmmm... I've used the same string locally and it runs... added more detail to the runs and the skip is happening due to:

The test wasn't able to connect to your webdriver instance. For more information read core/tests/README.md.
The original message while starting Mink: Could not open connection: Could not start a new session. Error while creating session with the driver service. Stopping driver service: Driver server process died prematurely.
Build info: version: '4.22.0', revision: 'c5f3146703'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.1.66-93.164.amzn2023.x86_64', java.version: '17.0.11'
Driver info: driver.version: unknown 
Host info: host: '3ad2463107b7', ip: '192.168.160.3'
Build info: version: '4.22.0', revision: 'c5f3146703'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.1.66-93.164.amzn2023.x86_64', java.version: '17.0.11'
Driver info: driver.version: unknown

Feel like I'm missing something simple.

catch’s picture

catch
he/him
Primary language English
commented

One possible difference between this and the usual runner is that the performance-test runner uses docker whereas the main runners use k8s. Pretty sure this is why we point to the image name instead of localhost because networking is different.

However we went through all of that before, so no idea why changing the image would break it now and I can't see a problem with the arguments being sent.

I tried adding --shm-size=2g because not having that had broken things locally for me, and it might have been a difference between docker and k8s, but that also hasn't helped. (https://git.drupalcode.org/project/drupal/-/jobs/2220842 is the most recent run).

catch opened merge request !8917

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

Put up an additional MR that moves the performance test back to the legacy driver:

https://git.drupalcode.org/project/drupal/-/jobs/2221126

I think we should do that, then open a follow-up (or maybe continue here for the commit history on the MR) to figure out how to get things onto selenium standalone. Also noticed the test only job is still using the legacy driver which I assume was an oversight in the original issue, so we should move that one too (although that'll be on k8s so should be straightforward).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Performance test gitlab job is broken » Performance test gitlab job is broken - revert to use chromedriver
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The tests are failing in the right way - they are missing the OTEL_COLLECTOR env variable that is set in the schedule. So the revert to use chromedriver will work fine. Created #3463696: Move performance test to selenium to fix this.

alexpott changed the visibility of the branch 3463534-legacy-for-now to hidden.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Yep let's land this for now and fix in a followup.

  • catch committed 0f9b2fff on 11.x 
    Issue #3463534 by alexpott, catch, longwave: Performance test gitlab job...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.