Closed (fixed)
Project:
Drupal core
Version:
10.4.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Jul 2024 at 12:40 UTC
Updated:
12 Feb 2025 at 00:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
annmarysruthy commentedComment #4
annmarysruthy commentedComment #6
annmarysruthy commentedComment #7
smustgrave commentedSeems to be some missed one
views.theme.inc
breakpoint.module
breakpoint.overview.html.twig
maybe a few more.
Comment #9
sheetal-wish commentedComment #10
ankitv18 commentedI found this reference http://www.w3.org in total 80 files and MR consists of changes in 52 files
Seems more files need to be taken care of.
Comment #11
nexusnovaz commentedIll take a quick look and see if i can get the rest
Comment #12
nexusnovaz commentedFound two more files which matched the problem. There is one last file which is contained in ckeditor5-dll.js. As this wasn't a normal file, i've left that one to be discussed. There are another 100 matches however, those are xmlns references.
Comment #13
ankitv18 commentedChanges looks good but not sure whether we need to consider .twig .php files having http://www.w3.org (Within svg xmlns)

Attaching screenshot for your reference.
Comment #14
ankitv18 commentedAlso synced the forked branch with 11.x
Comment #15
smustgrave commentedThink svgs should be a novice follow up
Comment #16
smustgrave commentedComment #17
smustgrave commentedAlso @ankitv18 please leave this for the newer users who were already working on it thanks
Comment #18
ankitv18 commented@smustgrave, I just reviewed and synced the forked branch
Comment #19
yujiman85 commentedTaking this on to make the other changes.
Comment #20
yujiman85 commentedI wasn't sure if the .js files needed to be touched since those seemed compiled and minified. Please correct me if I'm wrong. This needs a review.
Comment #21
smustgrave commentedWelcome @Yujiman85 and nice work!
Appears to need a rebase now though. Will keep an eye out for your changes.
Comment #22
quietone commentedThis is still a very large change. I am guessing a script is used to do this? Can it be shared?
Comment #23
yujiman85 commented@smustgrave Alright, I believe I did this right. I rebased the branch and it is up to date now with the commits from this branch. Needs a review.
Comment #24
ankitv18 commentedPipelines aren’t passing ~~ hence moving back into NW
Comment #25
rodrigoaguileraI think this needs a manual rebase since the "/rebase" gitlab command fails. The current pipeline fail doesn't make sense to me
Comment #26
ultimikeI will be working on this issue during the DrupalCon Barcelona mentored contribution with @pierregermain
After September 28, 2024, feel free to pick this issue up and continue.
-mike
Comment #27
pierregermain commentedRebased pierregermain made their first commit to this issue’s fork.
Comment #28
pierregermain commentedWe reverted the last commit that was introducing changes to svg files that made the pipeline fail. After reverting the commit, the pipeline is passing again. Needs Review.
Comment #29
lostcarpark commentedI have reviewed this issue and verified all the changes are to reference links, not XML or SVGs. All tests are passing.
Moving to RTBC.
Comment #32
quietone commentedI applied the diff and there are 4 occurrences, all of which are not to be modified.
git grep http://www.w3.org | grep -v .svgCommitted and pushed to 11.x and 10.4.x. Thanks!
Comment #35
quietone commentedThe comment #3399840-11: [meta] Replace http urls with https urls of the respective sites in core explains why the SVGs should not be changed, so I am removing the tag for a followup.