Problem/Motivation

Once #3421202: Enable W3C-compliant webdriver testing lands we will be able to deprecate non-W3C testing and drop support for it an major version of Drupal. We will also need to ensure that #3462681: Add W3C compliant JS testing is complete.

Proposed resolution

Deprecate non-W3C testing

Remaining tasks

User interface changes

None

API changes

TBD

Data model changes

None

Release notes snippet

To do

Issue fork drupal-3462682

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Postponed » Active

This can now be attempted - I think we should deprecate this in 11.2.0

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

longwave made their first commit to this issue’s fork.

longwave opened merge request !14614

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Let's try to get this into 11.4 for removal in 12.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work

We can add the --suppress-deprecations to the '🖱️️️ PHPUnit Functional Javascript (non W3C legacy)': test and that should allow them to pass.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Nice.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Deprecate non-W3C compliant testing » [PP-1] Deprecate non-W3C compliant testing
Status: Reviewed & tested by the community » Postponed

Blocked by #3463696: Move performance test to selenium

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Deprecate non-W3C compliant testing » Deprecate non-W3C compliant testing
Status: Postponed » Needs review

...and unblocked.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

... and ready to go!

  • catch committed d521cde5 on 11.x 
    task: #3462682 Deprecate non-W3C compliant testing

By: alexpott
By:...

  • catch committed 3c6ebc91 on main 
    task: #3462682 Deprecate non-W3C compliant testing

By: alexpott
By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14614

dcam’s picture

dcam commented

I had to update a local testing environment with this today while reviewing another issue. After I updated the MINK_DRIVER_ARGS_WEBDRIVER environment variable DDEV wouldn't restart properly. The problem was that I'd copied the new Chrome option, "w3c": true from the change record and it choked on the space after the colon with the error unexpected type map[string]interface {}. I'm happy to edit the CR, but I want to verify that this is a correct edit before I do.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.