• Add CI
  • Remove phpstan errors
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

VladimirAus created an issue. See original summary.

prudloff made their first commit to this issue’s fork.

prudloff’s picture

I removed Drupal 9/10 in core_version_requirement because I removed everything related to the editor.image_dialog route (which was removed in Drupal 11), but we might want to publish a transition release compatible with both Drupal 10 and Drupal 11 first.

vladimiraus’s picture

Version: 3.x-dev » 4.0.x-dev
Status: Active » Needs work
prudloff’s picture

phpstan is complaining that it does not find ckeditor (4) classes.
I think the solution would be to add drupal/ckeditor to dev dependencies in composer.json.
But do we want to keep supporting CKE 4? The ckeditor contrib module is abandoned and not compatible with D11.

laura.gates’s picture

Just as a FYI, the patch applies successfully but errors out when running drush updb:

[error] (Currently using Incompatible module The following module is installed, but it is incompatible with Drupal 10.4.6:
* Inline Styled Images

redeight’s picture

Looks like the core_version_requirement is being set from
core_version_requirement: ^9.3 || ^10
to
core_version_requirement: ^11

Which explains the error seen in #7. Until D10 is completely unsupported it would make sense to keep 10 as a supported version. Can we get it set as
core_version_requirement: ^10.1 || ^11

prudloff’s picture

The EditorImageDialog class and the editor.image_dialog route have been removed from Drupal 11, which is why I removed code related to this.
We can restore it but we will have to allow the "upgrade status" job to fail then because it will complain that EditorImageDialog is deprecated.

prudloff’s picture

Status: Needs work » Needs review

phpstan needs drupal/ckeditor to analyze its classes but this module can't be installed on Drupal 11 (and the CI uses Drupal 11).
I see no other solution than to allow the phpstan job to fail for now, we can then open a followup later about removing CKE 4 support.

laura.gates’s picture

@redeight. - setting the core version requirement to core_version_requirement: ^10.4 || ^11 likely makes the most sense given that 10.3 hits end of life next month.

jannakha’s picture

Status: Needs review » Needs work

CI is failing, for D11 it should be all green
+1 for #11 comment

prudloff’s picture

@jannakha the MR introduces new jobs that weren't checked before. IMHO fixing spelling issues and phpstan bad practices is out of scope for this issue and could be fixed in a followup issue.

Also see #10, I don't think we can make the phpstan job green while keeping support for CKE 4.
We could remove CKE 4 support in this MR, but I feel it would be better to remove it in a separate followup issue.

laura.gates’s picture

@VladimirAus

The plain diff and downloading the patch from github both don't apply. I'm using Drupal 10.4.6. Something else might be going on with this fork. If I get some downtime in the next couple of days, I'll try to isolate what's flagged in upgrade status:

modules/contrib/inline_responsive_images/src/Form/ResponsiveEditorImageDialog.php
modules/contrib/inline_responsive_images/inline_responsive_images.info.yml
modules/contrib/inline_responsive_images/composer.json

into its own fork

vishal choudhary changed the visibility of the branch 3462224-drupal-11-support to hidden.

laura.gates changed the visibility of the branch 3462224-D11-compatiblity-from-3.0.1 to hidden.

laura.gates changed the visibility of the branch 3462224-D11-compatiblity-from-3.0.1 to active.

laura.gates’s picture

The diff for targeting only the three issues flagged by upgrade status applies for me. I'm uploading it here as a patch. This should hold folks over while the issue with the 4.x branch is figured out.

laura.gates changed the visibility of the branch 3462224-drupal-11-support to active.

vishal choudhary changed the visibility of the branch 3462224-drupal-11-support to hidden.

vladimiraus changed the visibility of the branch 3462224-automated-d11-support to hidden.

vladimiraus changed the visibility of the branch 3462224-drupal-11-support to active.

vladimiraus’s picture

Status: Needs work » Needs review

CI is green and all CKEditor 4 references were removed.
Ready for review.

caspervoogt’s picture

This has been working fine on my end

jannakha’s picture

Status: Needs review » Reviewed & tested by the community

+1 RTBC

vladimiraus’s picture

Thank you for your contributions.
Released.

vladimiraus’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • vladimiraus committed 5839d2a0 on 4.0.x
    feat: #3462224 Drupal 11 support
    
    By: prudloff
    By: vladimiraus
    By:...

  • vladimiraus committed 03a5d93a on 4.0.x
    feat: #3462224 Drupal 11 support
    
    By: prudloff
    By: vladimiraus
    By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.