Closed (fixed)
Project:
Inline responsive images
Version:
4.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Jul 2024 at 01:54 UTC
Updated:
15 Feb 2026 at 02:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
prudloff commentedI removed Drupal 9/10 in core_version_requirement because I removed everything related to the editor.image_dialog route (which was removed in Drupal 11), but we might want to publish a transition release compatible with both Drupal 10 and Drupal 11 first.
Comment #5
vladimirausComment #6
prudloff commentedphpstan is complaining that it does not find ckeditor (4) classes.
I think the solution would be to add drupal/ckeditor to dev dependencies in composer.json.
But do we want to keep supporting CKE 4? The ckeditor contrib module is abandoned and not compatible with D11.
Comment #7
laura.gatesJust as a FYI, the patch applies successfully but errors out when running drush updb:
[error] (Currently using Incompatible module The following module is installed, but it is incompatible with Drupal 10.4.6:
* Inline Styled Images
Comment #8
redeight commentedLooks like the core_version_requirement is being set from
core_version_requirement: ^9.3 || ^10to
core_version_requirement: ^11Which explains the error seen in #7. Until D10 is completely unsupported it would make sense to keep 10 as a supported version. Can we get it set as
core_version_requirement: ^10.1 || ^11Comment #9
prudloff commentedThe EditorImageDialog class and the editor.image_dialog route have been removed from Drupal 11, which is why I removed code related to this.
We can restore it but we will have to allow the "upgrade status" job to fail then because it will complain that EditorImageDialog is deprecated.
Comment #10
prudloff commentedphpstan needs drupal/ckeditor to analyze its classes but this module can't be installed on Drupal 11 (and the CI uses Drupal 11).
I see no other solution than to allow the phpstan job to fail for now, we can then open a followup later about removing CKE 4 support.
Comment #11
laura.gates@redeight. - setting the core version requirement to core_version_requirement:
^10.4 || ^11likely makes the most sense given that 10.3 hits end of life next month.Comment #12
jannakha commentedCI is failing, for D11 it should be all green
+1 for #11 comment
Comment #13
prudloff commented@jannakha the MR introduces new jobs that weren't checked before. IMHO fixing spelling issues and phpstan bad practices is out of scope for this issue and could be fixed in a followup issue.
Also see #10, I don't think we can make the phpstan job green while keeping support for CKE 4.
We could remove CKE 4 support in this MR, but I feel it would be better to remove it in a separate followup issue.
Comment #14
laura.gates@VladimirAus
The plain diff and downloading the patch from github both don't apply. I'm using Drupal 10.4.6. Something else might be going on with this fork. If I get some downtime in the next couple of days, I'll try to isolate what's flagged in upgrade status:
modules/contrib/inline_responsive_images/src/Form/ResponsiveEditorImageDialog.php
modules/contrib/inline_responsive_images/inline_responsive_images.info.yml
modules/contrib/inline_responsive_images/composer.json
into its own fork
Comment #19
laura.gatesThe diff for targeting only the three issues flagged by upgrade status applies for me. I'm uploading it here as a patch. This should hold folks over while the issue with the 4.x branch is figured out.
Comment #25
vladimirausCI is green and all CKEditor 4 references were removed.
Ready for review.
Comment #26
caspervoogt commentedThis has been working fine on my end
Comment #27
jannakha commented+1 RTBC
Comment #28
vladimirausThank you for your contributions.
Released.
Comment #29
vladimiraus