Problem/Motivation

Issue when adding webform submission then trying to open results page.

Steps to reproduce

1- Add webform or use contact submission
2- Navigate to the webform results page

Proposed resolution

I found that the issue is likly from varbase_layout_builder_entity_operation hook, It adds only entity type id parameter webform submission requires webform parameter, So we need to check if the entity is webform submission and add webform parameter to it.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
CommentFileSizeAuthor
#2 3461988-2.patch730 bytesibrahim tameme

Comments

Ibrahim Tameme created an issue. See original summary.

ibrahim tameme’s picture

StatusFileSize
new730 bytes
rajab natshah’s picture

Status: Active » Closed (won't fix)
rajab natshah’s picture

Could be fixed in the same Webform module
try to update the Webform module first
They had a new release
if they did not commit the fix in webform
we could add a hook to fix this in varbase_webform
only the location is wrong.

  • try to fix in webform first ( file an issue for them)
  • try to fix this in your custom module ( TEMP ) in the project ( or use the patch for webform )
  • We can add it in Varbase Webform module
rajab natshah’s picture

Title: Issue when adding form submitting then trying to open results page » Fix Issue when adding form submitting then trying to open results page
Project: Varbase Layout Builder » Varbase Core
Version: 10.1.x-dev » 10.0.x-dev
Priority: Major » Normal
Status: Closed (won't fix) » Active

Moved to Varbase Core
Move the logic to have the fix in Varbase Webform
Create a new issue fork + a merge request

rajab natshah’s picture

Status: Active » Needs review
rajab natshah’s picture

Status: Needs review » Closed (won't fix)