Problem/Motivation

This is actually a todo within the code

* @todo Move to Shortcut module as part of the core MR process.

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navig...

Proposed resolution

Move this block into the shortcut module .

Remaining tasks

Move this block into the shortcut module .

User interface changes

N/A

API changes

N/A final class NavigationShortcutsBlock

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#9 Screenshot 2024-08-05 at 8.21.55 AM.png262.64 KBtrackleft2

Issue fork drupal-3461097

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

trackleft2 created an issue. See original summary.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes

pooja_sharma made their first commit to this issue’s fork.

pooja_sharma opened merge request !9066

pooja_sharma’s picture

pooja_sharma commented
Status: Active » Needs review

Moved the block in shortcut module along with respective test case.

Please review. moving NR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Small comment.

pooja_sharma’s picture

pooja_sharma commented
Status: Needs work » Needs review

Addressed the feedback, Please review moving NR

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

1 comment addressed.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
StatusFileSize
new Screenshot 2024-08-05 at 8.21.55 AM.png262.64 KB

Shortcut module still works after this change, looks good to me.

Screen shot of shortcut block in the navigation.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

I would like to point out that the block id is still prefixed with navigation_. Not sure if this is what we want. https://git.drupalcode.org/project/drupal/-/merge_requests/9066/diffs#f1...

If we change it, we may need to write a database update.
Additionally, we would need to update the .module file in order to continue allow selecting the shortcut block in the navigation layout builder

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Needs review

I'm marking this as needs review in case my comments should be considered as part of this MR. Feel free to change it back to Reviewed & tested by the community if my comments don't need consideration, sorry for the additional work.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Don't think the ID needs to change but block does actually need an update. Currently has a check for shortcut but being in the shortcut module this isn't needed but should check navigation.

pooja_sharma’s picture

pooja_sharma commented
Status: Needs work » Needs review

As per feedback, added navigation module check along with comment also updated, not sure apart from it, nothing seems to be left.

Please review, moving NR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Not sure if we will have to move the service too but currently as scoped believe this is good .

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

ShortcutLazyBuilder should be moved in this issue too, it only exists to support the block.

I also think we might want to wait to commit this one until the hard blockers for navigation to become stable are committed or at least close to RTBC - otherwise this block will be showing up on the UI on modules without navigation installed while it's still experimental.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 11.x to hidden.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Closed (outdated)

This happened as part of #3586214: Remove the Shortcut module

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.