Problem/Motivation
We have a message "Antibot (webform_submission_contact_node_66_add_form): disabled" but the form is protected with antibot because it enabled in the webform General settings Third party settings section.
From description of the option "Display form IDs" - "... Also displayed will be whether or not Antibot is enabled for each form. ...".
So it confusing.
Steps to reproduce
- Go to "/admin/config/user-interface/antibot" and enable option "Display form IDs".
- Go to webforms "/admin/webform" and create new webform.
- Go to new webform General settings page and check "Protect [Form name] webform with Antibot" at the bottom (Third party settings section), save.
- Go to the form page and see the massage like "Antibot (webform_submission_[your form id]_add_form): disabled" (you should have antibot permissions to see that message).
- Check form code and see <input data-drupal-selector="edit-antibot-key" type="hidden" name="antibot_key" value="11kB-206hV_yBrl**************">
Proposed resolution
Update "Display form IDs" logic to include that case and show correct message to users.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3460684-fixed4.png | 49.47 KB | danrod |
| #6 | 3460684-fixed2.png | 32.93 KB | danrod |
| #6 | 3460684-fixed3.png | 65.97 KB | danrod |
| #6 | 3460684-fixed1.png | 66.57 KB | danrod |
| #4 | 3460684-test3.png | 66 KB | danrod |
Issue fork antibot-3460684
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
danrodComment #3
danrodComment #4
danrodThis issue was raised a while ago, but yes, I could reproduce it:
Even if the new webform is not on the "Form IDs" list, by enabling "Antibot" at /admin/structure/webform/manage/menu_items/settings , it still shows as "disabled" just because it's not on that list.
I'll create a MR for this.
Comment #6
danrodI created a MR for this, so anytime the user sets the antibot protection via "Third Party Settings" in the webform, the form will be listed in the "Form IDs" box and it will show as "enabled":
I would like to some to test if, it not I'll move it to "Fixed" later tomorrow.
Comment #7
danrodComment #8
danrodComment #9
danrodComment #11
danrod