Running :-
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/entity_tracer/
returns the following warnings/errors, which should be fixed.

FILE: /home/prem/Documents/drupal-10.3.1/web/modules/contrib/entity_tracer/README.md
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 93 characters
11 | WARNING | Line exceeds 80 characters; contains 102 characters
14 | WARNING | Line exceeds 80 characters; contains 107 characters
15 | WARNING | Line exceeds 80 characters; contains 109 characters
22 | WARNING | Line exceeds 80 characters; contains 107 characters
24 | WARNING | Line exceeds 80 characters; contains 106 characters
26 | WARNING | Line exceeds 80 characters; contains 86 characters
28 | WARNING | Line exceeds 80 characters; contains 114 characters
29 | WARNING | Line exceeds 80 characters; contains 113 characters
------------------------------------------------------------------------------------

FILE: /home/prem/Documents/drupal-10.3.1/web/modules/contrib/entity_tracer/templates/entity-tracer-results.html.twig
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------

FILE: /home/prem/Documents/drupal-10.3.1/web/modules/contrib/entity_tracer/entity_tracer.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 228ms; Memory: 12MB

CommentFileSizeAuthor
#11 fix-phpcs-issues.png30.49 KBabhiyanshu
#7 Screenshot from 2024-07-08 16-18-51.png46.21 KBhetal.solanki

Issue fork entity_tracer-3459871

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Prem Suthar created an issue. See original summary.

Chandansha made their first commit to this issue’s fork.

Chandansha opened merge request !5

chandansha’s picture

chandansha commented
Status: Active » Needs review
hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: Unassigned » hetal.solanki
prem suthar’s picture

prem suthar commented
hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: hetal.solanki » Unassigned
Status: Needs review » Needs work
Issue tags: -phpcs +Coding standards
StatusFileSize
new Screenshot from 2024-07-08 16-18-51.png46.21 KB

i have tested MR 5 and i have found some error below:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/entity_tracer-3459871/

rloos289’s picture

rloos289 commented

I will accept this, but please fix the Readme. The current MR fixed the line length in a weird way,
- Line 17 has a random indent
- Lines 18,19, and 36-39 end prematurely

chandansha’s picture

chandansha commented
Status: Needs work » Needs review

please review i tryed to create new comment which will not look weird.
Thanks!!

abhiyanshu made their first commit to this issue’s fork.

abhiyanshu’s picture

abhiyanshu commented
StatusFileSize
new fix-phpcs-issues.png30.49 KB

I have thoroughly reviewed MR !5 and can confirm that it resolves all the PHPCS issues.
Excellent work on this! There are just a few minor updates needed in the README file to fully align with the standards.
For additional clarity, please refer to the attached screenshot.

@rloos289 Kindly review it now. Thank you!

rloos289’s picture

rloos289 commented
Status: Needs review » Fixed

Thanks folks. Merging and closing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.