Problem/Motivation

As is identified in a review of MR5:

Is this supposed to be asserting something? This doesn't actually prove anything, it just returns a boolean. I suspect you want this:

-   $this->page->hasField('rum_instrumentation');
+   $this->assertSession()->fieldExists('rum_instrumentation');

You probably want to change this for the rest of this test, too, in another issue.

This issue is created as a follow-up issue.

Proposed resolution

Update AdminUiTest::testSettingsPage() to assert ->fieldExists().

Remaining tasks

Open MR

User interface changes

None

API changes

None

Data model changes

None

Issue fork new_relic_rpm-3459804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chris Burge created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !9

sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review

Hi @Chris Burge.

I have created MR!9 for the above issue, Please review it once.

chris burge’s picture

chris burge commented
Status: Needs review » Reviewed & tested by the community

Needed to run tests. Maintainers should feel free to remove .gitlab-ci.yml file prior to merging and merge #3446404: Switch from Drupal CI to GitLab CI separately.

steven jones made their first commit to this issue’s fork.

steven jones’s picture

steven jones commented

LGTM.

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.