Problem/Motivation

SDC is part of core now, so we can migrate the existing code to take advantage of SDC.

Proposed resolution

Plan and move all the components into their own SDCs.

Remaining tasks

The plan for Phase 2 still needs to be defined to refactor and improve the code in the best way possible.

Phase 1 - Create the components

Phase 2 - Javascript and refactor/improvements/make things right

  • Events
  • Safe triangle refactor
  • Tooltip to core
  • Break the JS into components: @todo a proposal of specific steps and issues

User interface changes

There shouldn't be UI changes.

API changes

Data model changes

Release notes snippet

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue tags: +Navigation stable blocker

Note: I haven’t added as components the following items:

  • Admin Toolbar. I see this more as a region rather than a component
  • Top Bar. Same, I see this more as a a region
  • Body Scroll lock: I see this more as an utility

I know @finnsky had ideas to plan Phase 2, so leaving this here so he can work on it.

quietone’s picture

quietone commented
Version: 11.0.x-dev » 11.x-dev
jon nunan’s picture

jon nunan commented

Break the JS into components: @todo a proposal of specific steps and issues

By "components" are we talking Web Component custom elements, or just breaking the functionality up by SDC component?

I'd be a fan of exploring the first option as it would also allow some style encapsulation. I've started playing around with writing my front end themes with more a CUBE CSS (https://cube.fyi/) approach, but I find that often leads to conflicts with admin elements, so having admin elements outside the frontend css with Shadow DOM could be a nice win.

finnsky’s picture

finnsky commented

Thank you for your interest.

Specifically in this task we mean SDC Drupal components.

But of course we should keep in mind web components as a promising technology. Especially in the Navigation module because it should look the same in the context of any Drupal theme. (and any basic styles)

If you are interested in web components in the core, then I know two tasks where they can appear (sorry for the off-topic)

https://www.drupal.org/project/drupal/issues/3405822
https://www.drupal.org/project/drupal/issues/3100083

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Issue summary: View changes
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Issue tags: -Navigation stable blocker

This was added to #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable as 'Should have'. Updating here to reflect that it is now a Navigation stable blocker.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.