Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

Issue fork migrate_devel-3458112

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

NexusNovaz made their first commit to this issue’s fork.

nexusnovaz’s picture

nexusnovaz commented

Hey! I'll take a look at this!

nexusnovaz’s picture

nexusnovaz commented
Assigned: Unassigned » nexusnovaz

NexusNovaz opened merge request !6

nexusnovaz’s picture

nexusnovaz commented
Assigned: nexusnovaz » Unassigned
Status: Active » Needs work

Resolved cspell and most phpcs issues. I'm unsure how to properly resolve the final issues.

Remaining phpcs issue:

FILE: ...tom/migrate_devel-3458112/src/EventSubscriber/MigrationEventSubscriber.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 33 | ERROR | Variable "Source" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 34 | ERROR | Variable "Destination" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 43 | ERROR | Variable "Source" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 47 | ERROR | Variable "Destination" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 68 | ERROR | Variable "Source" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 69 | ERROR | Variable "Destination" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 70 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but
    |       | only $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 79 | ERROR | Variable "Source" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 83 | ERROR | Variable "Destination" starts with a capital letter, but only
    |       | $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
 87 | ERROR | Variable "DestinationIDValues" starts with a capital letter, but
    |       | only $lowerCamelCase or $snake_case is allowed
    |       | (Drupal.NamingConventions.ValidVariableName.LowerStart)
--------------------------------------------------------------------------------

Remaining phpstan issues:

 ------ --------------------------------------------------------------------- 
  Line   migrate_devel.drush.inc                                              
 ------ --------------------------------------------------------------------- 
  27     Function drush_get_option not found.                                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  55     Access to constant DEBUG on an unknown class Drush\Log\LogLevel.     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  112    Access to constant ALERT on an unknown class Drush\Log\LogLevel.     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ ---------------------------------------------------------------------
hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: Unassigned » hetal.solanki
hetal.solanki’s picture

hetal.solanki
Primary language English
commented

@batigolix, @NexusNovaz

I've fixed the last MR!6 pipeline issue.
so moving this issue into review.

Thank you!!

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Status: Needs work » Needs review
hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: hetal.solanki » Unassigned
deepak5423’s picture

deepak5423 commented
Status: Needs review » Reviewed & tested by the community

I have checked the issue and now its pass all the gitlab pipeline tests.
Moving the ticket to RTBC.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

  • batigolix committed 85fd053c on 8.x-2.x authored by NexusNovaz 
    Issue #3458112 by Hetal.Solanki, NexusNovaz, batigolix, deepak5423: Make...
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

Many thanks to all contributors.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.