Problem/Motivation
The theme selection form in the installer is broken since the update for Drupal core 10.3. The theme handler service was replaced by a theme extension list service, but not all the code in the form was updated. The code is still getting the theme handler from the service container.
See commit https://git.drupalcode.org/project/panopoly/-/commit/c51a5bbb0bd33b6669e....
Steps to reproduce
Create a new Panopoly site using the composer template.
Try to install via drush or the UI.
Note the error:
TypeError: Drupal\panopoly_theme\Form\PanopolyThemeSelectionForm::__construct(): Argument #1 ($theme_list) must be of type Drupal\Core\Extension\ThemeExtensionList, Drupal\Core\Extension\ThemeHandler given, called in /web/profiles/contrib/panopoly/modules/panopoly/panopoly_theme/src/Form/PanopolyThemeSelectionForm.php on line 86 in Drupal\panopoly_theme\Form\PanopolyThemeSelectionForm->__construct() (line 69 of /web/profiles/contrib/panopoly/modules/panopoly/panopoly_theme/src/Form/PanopolyThemeSelectionForm.php)
Proposed resolution
Fix the create() function.
Remaining tasks
Patch and test.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3457957-theme-selection-form-2.patch | 724 bytes | cboyden |
Issue fork panopoly-3457957
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
cboyden commentedSee MR and attached patch. This works locally in my testing.
Comment #4
dsnopekAck, I didn't see your patch, and just fixed this one independently.