[10.2] user_roles() and user_role_names() are deprecated

     // Use parameter FALSE to include 'Anonymous'.
-    $roles = user_role_names(FALSE);
+    $roles = Role::loadMultiple(FALSE);

This doesn't work.

loadMultiple() doesn't take a boolean argument.
You have to make sure that the value of $roles doesn't change. I suggest reading the change record that I linked.

Read what I said in #4.

Again, user_role_names() and Role::loadMultiple() DO NOT GENERATE THE SAME OUTPUT. You can't simply substitute one for the other. More work needs to be done.

The contents of $roles needs to be EXACTLY THE SAME after the change as it was before the change.

Here is a little drush script that demonstrates this is wrong. This prints the value of $roles with the old code then prints the value of $roles with the new code. Run this as drush php-script 3457135-roles.txt

I don't think Html::escape() is correct here, so I removed it. The original function user_role_names() does not use it. Also, this was discussed in the core issue linked in the change notice. Although the core patch did use it in some places, there was a follow-up issue to remove it.

Regardless, in Rules, this code appears in an OptionsProvider, and sanitation should not take place this early - that should be left to the rendering stage. We have no knowledge in the OptionsProvider about how the data will eventually be used, so IMO it is premature to modify it with escape().

Only need to address things caused by this MR, but there are none. I still trying to get all the tests back and running - they're failing due to changed in D10.3 and due to the change from DrupalCI to GitLabCI. I'm working on it, and it's almost all fixed now.