See the change record: RendererInterface::renderPlain() is deprecated in favour of ::renderInIsolation()

CommentFileSizeAuthor
#7 rules_resolve_deprecated_issue-3457134.patch993 bytesabhiyanshu
#5 deprecated-issues-resolved.png32.9 KBabhiyanshu

Issue fork rules-3457134

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

TR created an issue. See original summary.

sarwan_verma’s picture

sarwan_verma commented
Assigned: Unassigned » sarwan_verma

abhiyanshu_rawat made their first commit to this issue’s fork.

abhiyanshu_rawat opened merge request !37

abhiyanshu’s picture

abhiyanshu commented
Assigned: sarwan_verma » Unassigned
Status: Active » Needs review
StatusFileSize
new deprecated-issues-resolved.png32.9 KB

Hi @Tim,
I have resolved the issue with the deprecated code by using ::renderInIsolation(). Thanks.
Below are the files in which the issues have been resolved:

  • tests/src/Kernel/EntityViewTest.php
  • src/Logger/RulesDebugLog.php
tr’s picture

tr commented
Status: Needs review » Needs work

Look at your changes ... You merged 4.0.x into 8.x-3.x.

This issue is for 4.0.x.

abhiyanshu’s picture

abhiyanshu commented
StatusFileSize
new rules_resolve_deprecated_issue-3457134.patch993 bytes

Created patch for the same. Thanks.

abhiyanshu’s picture

abhiyanshu commented
Status: Needs work » Needs review
ankitv18’s picture

ankitv18 commented

@TR isn't the 4.0.x branch having minimum support of 10.2?

ankitv18 opened merge request !39

ankitv18 changed the visibility of the branch 3457134-10.3-rendererinterfacerenderplain-is to hidden.

ankitv18 changed the visibility of the branch 4.0.x to hidden.

ankitv18’s picture

ankitv18 commented

@TR I've closed other branches as they messed up and opened h new one. Please review the MR!39

tr’s picture

tr commented
Status: Needs review » Fixed

@TR isn't the 4.0.x branch having minimum support of 10.2?

4.0.x is intended to support core 10.3+ and core 11. There were a number of major changes in 10.3, things like this, and most of these things that are first deprecated in 10.3 will be removed in 11, so they need to be fixed now.

Regardless the MR fixes the issue. Merged. Thanks!

  • TR committed a61c9585 on 4.0.x authored by ankitv18 
    Issue #3457134 by abhiyanshu, ankitv18: [10.3] RendererInterface::...
tr’s picture

tr commented
Status: Needs review » Fixed

TR closed merge request !37

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.