Problem/Motivation

We've got some code possibly no longer needed, according to the comments, says it should go now that we're on panels 4.7+

Steps to reproduce

See patch

Proposed resolution

See patch

Remaining tasks

Review patch

User interface changes

Unknown

API changes

remove possibly redundant calls

Data model changes

N/A

CommentFileSizeAuthor
#9 IMG_3390.jpeg126.88 KBfjgarlin
#2 wxt-3457046-02.patch2.24 KBjoseph.olstad

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new wxt-3457046-02.patch2.24 KB

New patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Suggested commit command which provides author credit on commit:

git commit -m 'Issue #3457046: Code comments in wxt_ext_layout say to remove these' --author="Joseph Olstad <20895-joseph.olstad@users.noreply.drupalcode.org>"

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

straight from wxt_ext_layout.module:

@todo Remove when we require Panels 4.5 or later, since it implements and tests this functionality itself

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
sylus’s picture

sylus commented
Status: Needs review » Fixed

Commit and attributed :)

I'm still curious why this doesn't display anymore on the credit and committing section. :(

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I mentioned to Drumm and someone else about this on Slack in the d.o infra channel, they weren't happy with the way I brought it up. Maybe find the channel on slack and nudge them a bit more on this. Could probably get them to restore this functionality. I have no idea why they turned it off, still don't understand their response.

fjgarlin’s picture

fjgarlin commented
StatusFileSize
new IMG_3390.jpeg126.88 KB

Even setting the author, credit wouldn’t be given. Credit is only given/assigned via the checkboxes table at the bottom.

The author of the commit is just the creator of the MR.

As of right now, none of you have “credits”.
Credits

Note that the credit system stopped parsing commit messages years ago. It only looks at the table to assign credits.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

yes but git keeps author information, there's issue credit for d.o and commit author, two different things. They are related but NOT the same.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Fixed » Active
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.