Needs review
Project:
Config Distro
Version:
3.0.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Jun 2024 at 01:54 UTC
Updated:
31 Mar 2026 at 01:01 UTC
Jump to comment: Most recent
Problem/Motivation
Output from PHPStan (see #3456892: GitLabCI: Fix existing PHPStan issues):
------ ----------------------------------------------------------------
Line src/Form/ConfigDistroImportForm.php
------ ----------------------------------------------------------------
18 Class Drupal\config_distro\Form\ConfigDistroImportForm extends
@internal class Drupal\config\Form\ConfigSync.
We should explore alternative implementations for ConfigDistroImportForm that don't require extending an internal class.
Complicating considerations:
- The config_sync module extends the config distro import form class (see https://git.drupalcode.org/project/config_sync/-/blob/3.0.x/src/Form/Con...)
- The config_distro_ignore submodule alters the config distro import form: https://git.drupalcode.org/project/config_distro/-/blob/2.0.x/modules/co...
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork config_distro-3456896
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
joegraduateComment #3
joegraduateComment #6
joegraduateComment #7
trackleft2Comment #8
joegraduateComment #9
joegraduateAn alternative approach we could consider would be to create a trait similar to the one used in config_split and config_checkpoint_ui that contains the essential import form code from the core form and use that in our form without extending the core form:
https://git.drupalcode.org/project/config_split/-/blob/2.0.x/src/Form/Co...
https://git.drupalcode.org/project/config_checkpoint_ui/-/blob/1.0.x/src...
Comment #12
joegraduateCreated an alternate MR that utilizes the trait based approach used by config_split.