Problem/Motivation

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------- 
  Line   src/Form/ConfigDistroImportForm.php                             
 ------ ---------------------------------------------------------------- 
  18     Class Drupal\config_distro\Form\ConfigDistroImportForm extends  
         @internal class Drupal\config\Form\ConfigSync.                  
  94     Call to an undefined static method                              
         Drupal\config\Form\ConfigSync::finishBatch().                   
 ------ ---------------------------------------------------------------- 
 [ERROR] Found 2 errors

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_distro-3456892

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joegraduate created an issue. See original summary.

joegraduate opened merge request !15

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Assigned: joegraduate » Unassigned
Status: Active » Needs review

Created MR !15 that:

I also created a separate issue for exploring alternative implementations for ConfigDistroImportForm that don't require extending an internal class (#3456896: Explore alternatives to extending internal core ConfigSync form class).

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2959209: Create rigurous tests

This looks good to me RTBC

My only thought was that we could add a test to determine whether the proper events are fired, but that can be a follow-up or part of the "Create Rigorous Tests" ticket.

  • joegraduate committed c4ab9be3 on 2.0.x 
    Issue #3456892 by joegraduate, trackleft2: GitLabCI: Fix existing...
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Reviewed & tested by the community » Fixed

Merged.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.