Closed (fixed)
Project:
Web Experience Toolkit
Version:
5.2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jun 2024 at 21:51 UTC
Updated:
30 Jul 2024 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
liquidcms commentedPatch attached.
Comment #3
liquidcms commentedComment #4
liquidcms commentedComment #5
joseph.olstadTo ensure proper author credit is given to @liquidcms with this commit , the commit command should be as follows:
git commit -m 'Issue #3456872 by liquidcms: LB inline blocks are no longer translatable' --author="Peter Lindstrom <24279-liquidcms@users.noreply.drupalcode.org>"uid 24279 is Liquidcms uid on drupalcode.org
drupal.org used to provide this git command for us but was removed recently. Now it has to be done this way ^.
Comment #6
joseph.olstadAs a maintainer of another project, I was just reminded to check the checkboxes for issue credit.
This should be done also in wxt:
Only a maintainer has access to check these boxes and make the checkmark persist.
See screenshot:

There should be a checkbox put beside @liquidcms in this case
Once the issue is Fixed and then eventually "Closed (Fixed)" , the issue credit is then a reference from the d.o users profile.
Comment #7
sylus commentedAh thanks @joselph.olstad and @liquidcms, especially for the note that they removed the attribution options?
Was there explanation why Drupal.org removed the --author attribution in the iisue commit screen?
Was it because they are preferring Merge Requests over the patch workflow?
Either way every commit should ALWAYS reflect the owner who author/contributed who contributed their time and effort so if I ever missed a authorship attribution on a commit or anything let me know and I will fix it.
I can also add both of you to commit access on the latest branch if helps.
It is still nice to have an issue with patch attached though I know I need to do that myself better.
Comment #8
sylus commentedCommitted and attributed!
Comment #11
joseph.olstadChecked "By LiquidCMS" checkbox for credit