Problem/Motivation

As detailed here: #3411037: Contextual links for translation are removed by core, Drupal 10.2 introduced code to "clean" up LB contextual links on blocks. As a downside to this it removes the contextual link added by the Layout Builder Symmetric Translations module which WxT uses to allow translation of blocks placed in LB.

The following patch adds the patch to WxT's composer.json.

I am providing the patch as i don't appear to have commit access to the WxT repository. If there is some other mechanism that I am given commit credit for this that is fine.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

liquidcms created an issue. See original summary.

liquidcms’s picture

Status: Active » Needs review
StatusFileSize
new792 bytes

Patch attached.

liquidcms’s picture

Issue summary: View changes
liquidcms’s picture

Issue summary: View changes
joseph.olstad’s picture

To ensure proper author credit is given to @liquidcms with this commit , the commit command should be as follows:

git commit -m 'Issue #3456872 by liquidcms: LB inline blocks are no longer translatable' --author="Peter Lindstrom <24279-liquidcms@users.noreply.drupalcode.org>"

uid 24279 is Liquidcms uid on drupalcode.org

drupal.org used to provide this git command for us but was removed recently. Now it has to be done this way ^.

joseph.olstad’s picture

As a maintainer of another project, I was just reminded to check the checkboxes for issue credit.

This should be done also in wxt:

Only a maintainer has access to check these boxes and make the checkmark persist.

See screenshot:
Issue credit

There should be a checkbox put beside @liquidcms in this case

Once the issue is Fixed and then eventually "Closed (Fixed)" , the issue credit is then a reference from the d.o users profile.

sylus’s picture

Ah thanks @joselph.olstad and @liquidcms, especially for the note that they removed the attribution options?

Was there explanation why Drupal.org removed the --author attribution in the iisue commit screen?

Was it because they are preferring Merge Requests over the patch workflow?

Either way every commit should ALWAYS reflect the owner who author/contributed who contributed their time and effort so if I ever missed a authorship attribution on a commit or anything let me know and I will fix it.

I can also add both of you to commit access on the latest branch if helps.

It is still nice to have an issue with patch attached though I know I need to do that myself better.

sylus’s picture

Status: Needs review » Fixed

Committed and attributed!

  • sylus committed 7e51a34c on 5.2.x authored by liquidcms
    Issue #3456872 by liquidcms: LB inline blocks are no longer translatable
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

Status: Closed (fixed) » Fixed

Checked "By LiquidCMS" checkbox for credit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.