Problem/Motivation

Wanting to do a small change for PHPStan, https://git.drupalcode.org/project/menu_per_role/-/merge_requests/15, It demonstrated that tests are failing on core 10.3.

Issue fork menu_per_role-3456797

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

Grimreaper opened merge request !16

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work

I managed to fix some changes but I have not been able to find the root cause of the remaining failures yet.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Also maybe need to create a new branch with 10.3 minimum requirements and on 8.x-1.x ensure tests are executed on core 10.2.

niber’s picture

niber commented
Assigned: Unassigned » niber
niber’s picture

niber commented
Assigned: niber » Unassigned
grask0’s picture

grask0 commented
Assigned: Unassigned » grask0
grask0’s picture

grask0 commented
Assigned: grask0 » Unassigned
Status: Needs work » Needs review

Hello,

I added full support for running the automated test suite against Drupal 10.2. This includes updates to the CI configuration, so that tests are executed and validated specifically on Drupal 10.2.

snap_x’s picture

snap_x
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me. Thanks @grask0

grask0’s picture

grask0 commented
Status: Reviewed & tested by the community » Fixed

Merged!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Fixed » Needs work

Hi,

Thanks for your work.

The original problem was to ensure tests are green on the latest Core version.

I guess that tests remains broken on 10.3 and above.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Fixed

Remarking as fixed.

Update for 10.3 to be done in #3456786: Remove user 1 special behavior

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.