Problem/Motivation

Now that https://www.drupal.org/node/2910500 is in core, it is less expected that uid 1 is an admin.

Getting rid of special behavior for user uid 1 ensure better consistency.

Remaining tasks

Need to open a new branch: 2.0.x
Raise core requirement to 10.3
Remove code handling uid 1
Fix tests

User interface changes

Some settings form element description.

Issue fork menu_per_role-3456786

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grask0 made their first commit to this issue’s fork.

grask0’s picture

grask0 commented
Assigned: Unassigned » grask0

grask0 opened merge request !20

grask0’s picture

grask0 commented
Assigned: grask0 » Unassigned
Status: Active » Needs review

Hello,

I have implemented the requested changes.
The updates include:

  • Updated tests to ensure proper coverage and compatibility.
  • Raised the minimum required Drupal core version to 10.3.
  • Removed references to user ID 1, since relying on UID 1 is no longer appropriate.

Additionally, this code can be further refactored in the future.
Specifically, the MenuPerRoleAdminAccessTest test may be removed entirely, because as of Drupal core 10.3, the access logic has changed: all admin users now have access to menu links in the admin UI regardless of admin_bypass_access_admin.

o_timoshchuk’s picture

o_timoshchuk commented
Assigned: Unassigned » o_timoshchuk
o_timoshchuk’s picture

o_timoshchuk commented
Assigned: o_timoshchuk » Unassigned
Status: Needs review » Reviewed & tested by the community

The merge request was successfully reviewed. It's ready to be merged.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Reviewed & tested by the community » Needs work

Hi,

Thanks for your work here, regarding changes from #3456797: Fix tests on core 10.3, the hardcoded Core version in .gitlab-ci.yml needs to be removed to have CI executed on the latest Core version.

grask0’s picture

grask0 commented

Hello Florent!

This code from the merge request needs to be added to the new 2.x branch. When I created this merge request, I didn’t have the option to create a branch.
Can I create a new branch, or will you handle it?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 8.x-1.x-dev » 2.x-dev

Hello Andriy,

I have created the new branch.

I think you have the permissions to create if.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

As I don't have all the permissions myself on this project, I can't set 2.x as the new default branch in Gitlab.

grask0 opened merge request !21

grask0 closed merge request !20

grask0 changed the visibility of the branch 2.x to hidden.

grask0’s picture

grask0 commented
Status: Needs work » Needs review

Hey,

I have updated the merge request.
Please take a look.

Thanks!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » grask0
Status: Needs review » Needs work

Hello @grask0,

Thanks for your MR, I put some review comments.

And happy new year!

grask0’s picture

grask0 commented
Assigned: grask0 » grimreaper
Status: Needs work » Needs review

Hello Florent!

Thanks for your review!
I have added some updates. Please take a look.

  • grimreaper committed ddb783dc on 2.x authored by grask0 
    feat: #3456786 Remove user 1 special behavior

By: grimreaper
By: grask0...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

merged, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.