Problem/Motivation

Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in Drupal\advanced_datalayer\Form\AdvancedDatalayerDefaultsForm->form() (line 153 of modules/contrib/advanced_datalayer/src/Form/AdvancedDatalayerDefaultsForm.php).

Steps to reproduce

Just installed & enabled module and went to add a new page variables:
/admin/config/search/advanced-datalayer/page-variables/add

CommentFileSizeAuthor
#6 Screenshot from 2024-06-26 11-14-37.png99.05 KButtam
#6 Screenshot from 2024-06-26 11-25-05.png63.32 KButtam

Issue fork advanced_datalayer-3456701

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tvalimaa created an issue. See original summary.

abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: Unassigned » abhishek_gupta1

abhishek_gupta1 opened merge request !9

abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: abhishek_gupta1 » Unassigned
Status: Active » Needs review

fixed the issue and created MR. please review it once.

tvalimaa’s picture

tvalimaa commented

looking good

uttam’s picture

uttam commented
StatusFileSize
new Screenshot from 2024-06-26 11-25-05.png63.32 KB
new Screenshot from 2024-06-26 11-14-37.png99.05 KB

The error is not showing after attaching the patch from the MR of @abhishek_gupta, LGTM
Moving it to RTBC

uttam’s picture

uttam commented
Status: Needs review » Reviewed & tested by the community
vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented
Version: 2.0.0 » 2.x-dev
Priority: Minor » Normal

kenniec’s picture

kenniec commented
kenniec’s picture

kenniec commented
Status: Reviewed & tested by the community » Fixed
kenniec’s picture

kenniec commented
Status: Fixed » Closed (fixed)