Problem/Motivation

I am currently hanging around the latest release Drupal version 10.3.x and I have running environment as below,

  • Drupal Version: 10.3.0
  • PHP version: 8.2
  • Lightning core: 8.x-5.14

I am facing issue while running composer install with 10.3.0 and lightning core version 5.14. It fails to apply patch https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch which is added inside the lightning core 5.14.

Error:

Cannot apply patch 2869592 - Disabled update module shouldn't produce a status report warning (https://www.drupal.org/files  
  /issues/2869592-remove-update-warning-7.patch)!

Steps to reproduce

1) Update your environment with latest Drupal 10.3.0
2) Lightning media version 8.x-5.14
3) run composer install

Proposed resolution

Proposed solution is to apply latest patch: https://www.drupal.org/files/issues/2024-06-14/2869592-disabled-update-m... from the issue: https://www.drupal.org/node/2869592

and release latest lightning_core module version with this change.

CommentFileSizeAuthor
#15 system-workaround-for-2869592.patch1.19 KBkorn3000
#14 lightning_core-remove-not-applicaple-patch.patch675 bytesmikeocana

Issue fork lightning_core-3456175

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smitghelani created an issue. See original summary.

smitghelani’s picture

smitghelani commented
Issue summary: View changes
smitghelani’s picture

smitghelani commented

This existing patch is obstructing the latest version upgrade of Drupal 10.3.0. so need to fix as soon as possible, if anyone from contributor of this module can please help to release latest version this module.

smitghelani’s picture

smitghelani commented

Also, I will request that if someone can help to fix this issue: https://www.drupal.org/project/lightning_core/issues/3456184 with same version and facilitate it's fix release together with this same upcoming release then will be best help.

smitghelani opened merge request !35

smitghelani closed merge request !35

smitghelani’s picture

smitghelani commented

Open MR is already there with same fix : https://git.drupalcode.org/project/lightning_core/-/merge_requests/33
but i tried same patch but not working for me so raised another MR with patch mentioned in proposed resolution.

smitghelani opened merge request !36

nicole_cf’s picture

nicole_cf commented

i have the same issue

robbdavis’s picture

robbdavis commented

I have the same issue. Unfortunately lightning is still so tightly interwoven with my site that I haven't been able to fully divest it. Now this patch from a module (ugh!) won't apply.

robbdavis’s picture

robbdavis commented

There is another issue dealing with this. This one should be closed. But the code to ignore the patch from #6 in that thread worked for me:

 "enable-patching": true,
  "patches-ignore": {
     "drupal/lightning_core": {
       "drupal/core": {
         "2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch"
       }
     }
   },
  "patches": {
nicole_cf’s picture

nicole_cf commented

Thankssssssssssssssss it`ssss workssssssssssss

bala_28’s picture

bala_28 commented

Seems its not working with Drupal 10.3.5
Anyone tired with this version?

mikeocana’s picture

mikeocana commented
StatusFileSize
new lightning_core-remove-not-applicaple-patch.patch675 bytes

Still encountering issues upgrading to 10.3.0 I just created a patch to remove it from the composer.json of lightning_core

korn3000’s picture

korn3000 commented
StatusFileSize
new system-workaround-for-2869592.patch1.19 KB

another temporary workaround to fix the problem for 10.3
instead remove or ignore old patch I added small core patch to let '2869592-remove-update-warning-7.patch' patch work :-)

m1b5g85’s picture

m1b5g85 commented

Facing the same issue while upgrading to 10.3.6. Tried applying the lightning_core-remove-not-applicaple-patch.patch but it's not working for me. Any suggestions?

rjustin’s picture

rjustin commented

I can confirm with @robbdavis (#11) that the course of action to circumvent this issue is to apply the code in #6. This allowed us to update a site from D10.2.6 to 10.3.10.