Problem/Motivation

    $cacheability = $computed_field_plugin->getCacheability($entity, $field_definition);
    $cacheability->applyTo($build['field']);

getCacheability can return NULL!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 computed_field-3455750-1.patch736 bytesjagraj_singh_gill

Issue fork computed_field-3455750

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

kalpanajaiswal made their first commit to this issue’s fork.

kalpanajaiswal opened merge request !13

kalpanajaiswal’s picture

kalpanajaiswal commented

Raised the MR with condition.

kalpanajaiswal’s picture

kalpanajaiswal commented
Status: Active » Needs review
jagraj_singh_gill’s picture

jagraj_singh_gill commented
StatusFileSize
new computed_field-3455750-1.patch736 bytes

Patch to check the truthy value.

jagraj_singh_gill opened merge request !14

jagraj_singh_gill’s picture

jagraj_singh_gill commented

According to @joachim 's suggestion instead of checking the instance I have applied the condition to check the truthy value. I have placed the MR , please review once. Thanks !

  • joachim committed ca2488ee on 4.0.x 
    Issue #3455750 by kalpanajaiswal, jagraj_singh_gill: Fixed viewField()...
joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.