I was working in some contrib hook_boot code recently, and noticed that I had to perform a full bootstrap just to use node_load/node_load_multiple with drupal_load('module', 'node') because there is a call to drupal_schema_fields_sql(), which is in common.inc. The same applies to taxonomy_term_load/taxonomy_term_load_multiple. I suggest moving drupal_schema_fields_sql() to bootstrap.inc.

CommentFileSizeAuthor
#1 345497-mov-drupal-schema-fields-sql-D7.patch2.33 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
345497-mov-drupal-schema-fields-sql-D7.patch2.33 KB
Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

It sounds weird to move that function to bootstrap.inc. Why not database.inc, where it can make new database friends?

Status: Needs review » Needs work

The last submitted patch failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review

Testing failure on slave #8.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Needs work

Review #2 still stands.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

My main reason for moving it to bootstrap.inc is because we have a group of schema API functions there already, like drupal_get_schema().

Jooblay.net’s picture

Jooblay.net CreditAttribution: Jooblay.net commented
Issue summary: View changes

What is the status of this ticket:) Can we close this...