Problem/Motivation

guzzle 7 introduced breaking changes that required xeroclient to be completely refactored. Luckily xero module uses the static method.

Proposed resolution

- Remove XeroNullClient and replace with better exception handling around XeroRequestException.
- Remove use of InvalidOptionsException

Remaining tasks

- Update dependency and make required code changes.
- Fix breaking changes, examples, documentation

User interface changes

No

API changes

Yes, methods on XeroClient that were inherited from Client will not be there with the exception of request, get, post and put.

Data model changes

No

Issue fork xero-3454689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mradcliffe created an issue. See original summary.

mradcliffe opened merge request !13

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

Blocks reopening #3455330: Automated Drupal 11 compatibility fixes for xero

  • mradcliffe committed 29663912 on 3.1.x 
    Issue #3454689 by mradcliffe: Updates xeroclient to support guzzlehttp...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Fixed

I literally have to merge this in order to manually test this because composer :|

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Fixed » Needs work

Yeah, it's broken upstream in my recent changes.

Why did guzzle have to get so much worse of a library? Sigh.

  • mradcliffe committed 44a27fd3 on 3.1.x 
    Issue #3454689 by mradcliffe: Updates to use xeroclient:0.5.3
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review

  • mradcliffe committed 7a96b20e on 3.1.x 
    Issue #3454689 by mradcliffe: Fixes missing method stubs on deprecated...

  • mradcliffe committed ebfec8da on 3.1.x 
    Issue #3454689 by mradcliffe: Updates to support 10.3 or greater with...

  • mradcliffe committed 2ea0c470 on 3.1.x 
    Issue #3454689 by mradcliffe: Updates test trait to use attribute...

  • mradcliffe committed 43530dc1 on 3.1.x 
    Issue #3454689 by mradcliffe: Fixes issues from downstream commerce_xero...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.