Replace readme.txt with readme.md.

Issue fork optional_end_date-3452694

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sunil Jolapara created an issue. See original summary.

kalpanajaiswal made their first commit to this issue’s fork.

kalpanajaiswal opened merge request !5

kalpanajaiswal’s picture

kalpanajaiswal commented

MR created to replace readme.txt file to readme.md file.

kalpanajaiswal’s picture

kalpanajaiswal commented
Status: Needs work » Needs review
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work

Hi

I reviewed MR!5 and the Project name and introduction section it's missing a link to the project page and issue queue, and remove the duplication of the 'of' word This will mimic the behavior of of optional end .

Thanks.

birk’s picture

birk commented

I don't intent to use GitLab CI, if you would remove it from the fork I'll merge it afterwards.

deepak5423 made their first commit to this issue’s fork.

deepak5423’s picture

deepak5423 commented
Status: Needs work » Reviewed & tested by the community

Removed gitlab-ci file.
Moving the ticket to need review.

deepak5423’s picture

deepak5423 commented
Status: Reviewed & tested by the community » Needs review
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work

Hi deepak5423

I reviewed MR!5 the added project page and issue queue should not be in bulleted list, it should be formatted like this as per README.md.

For a full description of the module, visit the
[project page](https://www.drupal.org/project/admin_menu).

Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/admin_menu).

Thanks

deepak5423’s picture

deepak5423 commented
Status: Needs work » Reviewed & tested by the community

Updated the README.md file.
Please review.

deepak5423’s picture

deepak5423 commented
Status: Reviewed & tested by the community » Needs review
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community

Hi deepak5423

I reviewed your changes and it fixed the comment #11 issue. Readme.md now follows the README template.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Thanks

birk’s picture

birk commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -

Hi thanks for all the work. I've merged the request.

I'm new to merges and credit, so of course I did it wrong. I'm so sorry about that.

I'll make sure to include all the people who helped in the release notes.
I'm aware this doesn't show up on your Drupal profile, again sorry.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.