Closed (fixed)
Project:
Experience Builder
Component:
Miscellaneous
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2024 at 13:31 UTC
Updated:
18 Jun 2024 at 16:29 UTC
Jump to comment: Most recent
#3451626: Unit tests for PropExpressions to go to/from string representation + single StructuredDataPropExpression::from(…) method is ready and has been approved by @Felix. All feedback from @larowlan’s overnight review has been addressed.
I can’t approve it, Ted is out, Lauri/Ben/Jesse aren’t the right people to ask this particular issue.
That means this is now blocked on Lee and/or Ted. Another ~24 hours in the best case. Not ideal.
I’m thinking now that we should have only a single other approver for /tests/ , at least in this early stage. WDYT?
- Wim: +1
- Felix: +1
- Jesse: +1
Let's revisit this after #3450586: [META] Back-end Kanban issue tracker and/or #3450592: [META] Front-end Kanban issue tracker are done.
Issue fork experience_builder-3452478
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #5
wim leersPeople were skeptical when I first set this up ~2.5 weeks ago. They were right 😅
Comment #6
lauriiiDoes a single approver mean that it's author + 1 reviewer? If that's the case, +1 for the proposal.
Comment #7
wim leers@lauriii: Yes, exactly :) Still impossible to approve your own MR if it's touching tests.
Comment #8
wim leers