Fix linting errors being reported in the Gitlab pipelines:

This includes:

- [x] PHPCS fixes
- [x] CSpell fixes
- [x] PHPStan fixes
- [x] Adding CI support for next major/minor Drupal version
- [x] Adding CI support for previous major Drupal version

Issue fork openid_connect-3452009

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

John Franklin created an issue. See original summary.

John Franklin opened merge request !110

john franklin’s picture

john franklin commented
Status: Active » Needs review

Submitted MR.

The first item appears to be a false positive. The OpenIDConnectClientFormBase::exists() function is a match with similar functions in Drupal core, and no warning, error, or exception is generated.

The rector doesn't realize the ConfigFormBase constructor has changed.

Tested with D11 + login_gov.

solideogloria’s picture

solideogloria commented
Issue tags: +Drupal 11 compatibility
solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work

murat_kekic made their first commit to this issue’s fork.

pfrilling made their first commit to this issue’s fork.

pfrilling’s picture

pfrilling
Location Minster, OH
commented
Title: Drupal 11 Compatibility with OIDC 3.x » Cleanup CI pipeline to ensure all validations pass.
Issue summary: View changes
Status: Needs work » Needs review

The changes proposed here were out of date so I:

- rebased with the latest 3.x
- fixed all phpcs linting errors
- fixed all cspell errors
- fixed all phpstan errors

Would love someone to review my edits to confirm my changes look okay.

pfrilling’s picture

pfrilling
Location Minster, OH
commented
Issue summary: View changes
ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Status: Needs review » Reviewed & tested by the community
pfrilling’s picture

pfrilling
Location Minster, OH
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

This has been merged to 3.x.

pfrilling’s picture

pfrilling
Location Minster, OH
commented

Attributing credit. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.