Problem/Motivation

#981870: Skip default argument for view URL does not work and never has so it can be removed was committed without deprecation support, this means that approximated 1,500 contrib views don't trigger deprecation notices when modules are installed.

We could add deprecation support now to 10.3.x (and 10.4.x), and then modules with deprecation testing on would be warned before they declare 11.x compatibility, as long as they have test coverage.

See [#/3443942] for the general problem. And see #2640994: Fix label token replacement for views entity reference arguments for an issue that handles things correctly.

Steps to reproduce

Proposed resolution

Remaining tasks

#7

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3450868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

Lendude made their first commit to this issue’s fork.

Lendude opened merge request !8559

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review

Something like this I guess

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Needs work

As the test failures indicate, we missed removing some, or some new instances of Views with default_argument_skip_url got added afterwards

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

I think the remaining failures mean the database fixtures need to be updated? I think?

catch’s picture

catch
he/him
Primary language English
commented

The update should disable deprecation triggering probably - since we know that views that we update will need the change to be made.

quietone’s picture

quietone commented
Version: 10.4.x-dev » 11.x-dev
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.6.x-dev

This update is only in 10.x

quietone opened merge request !12537

quietone closed merge request !8559

quietone changed the visibility of the branch 3450868-add-viewsconfigupdater-deprecation to hidden.

quietone’s picture

quietone commented
Issue summary: View changes

@catch, sorry about that.

I went to update the MR and made a mess of it that I was not able to recover from. I made a new MR and hide, and closed, the original.

I am not sure what #7 means. @catch?

catch’s picture

catch
he/him
Primary language English
commented

@quietone as far as I know all the 11.x views post updates and associate code handle this correctly, e.g.:


/**
 * Post update configured views for entity reference argument plugin IDs.
 */
function views_post_update_views_data_argument_plugin_id(?array &$sandbox = NULL): void {
  /** @var \Drupal\views\ViewsConfigUpdater $view_config_updater */
  $view_config_updater = \Drupal::classResolver(ViewsConfigUpdater::class);
  $view_config_updater->setDeprecationsEnabled(FALSE);
  \Drupal::classResolver(ConfigEntityUpdater::class)->update($sandbox, 'view', function (ViewEntityInterface $view) use ($view_config_updater): bool {
    return $view_config_updater->needsEntityArgumentUpdate($view);
  });
}

/**
 * Clean-up empty remember_roles display settings for views filters.
 */
function views_post_update_update_remember_role_empty(?array &$sandbox = NULL): void {
  /** @var \Drupal\views\ViewsConfigUpdater $view_config_updater */
  $view_config_updater = \Drupal::classResolver(ViewsConfigUpdater::class);
  $view_config_updater->setDeprecationsEnabled(FALSE);
  \Drupal::classResolver(ConfigEntityUpdater::class)->update($sandbox, 'view', function (ViewEntityInterface $view) use ($view_config_updater): bool {
    return $view_config_updater->needsRememberRolesUpdate($view);
  });
}

/**
 * Adds a default table CSS class.
 */
function views_post_update_table_css_class(?array &$sandbox = NULL): void {
  /** @var \Drupal\views\ViewsConfigUpdater $view_config_updater */
  $view_config_updater = \Drupal::classResolver(ViewsConfigUpdater::class);
  $view_config_updater->setDeprecationsEnabled(FALSE);
  \Drupal::classResolver(ConfigEntityUpdater::class)->update($sandbox, 'view', function (ViewEntityInterface $view) use ($view_config_updater): bool {
    return $view_config_updater->needsTableCssClassUpdate($view);
  });
}

$view_config_updater->setDeprecationsEnabled(FALSE); in the post update ensures that no deprecations are triggered by the update path, but deprecation support in ViewsConfigUpdater itself allows them to be triggered by presave hooks.

#3521618: Add generic interface + base class for upgrade paths that require config changes and #3521618: Add generic interface + base class for upgrade paths that require config changes have more discussion.