Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3450567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

kalpanajaiswal made their first commit to this issue’s fork.

kalpanajaiswal opened merge request !8309

kalpanajaiswal’s picture

kalpanajaiswal commented

Merge request created to add the comment on construct object.
MR: https://www.drupal.org/project/drupal/issues/3450567

joachim’s picture

joachim commented
Status: Active » Needs work

Good start but I don't think the first param is right.

kalpanajaiswal’s picture

kalpanajaiswal commented

First param comment updated as per the parent class

joachim’s picture

joachim commented
Status: Needs work » Reviewed & tested by the community

Looks good. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 55e32b3103 to 11.x and 18daefd77d to 11.0.x and 1723897e5a to 10.4.x and 372e818dd8 to 10.3.x. Thanks!

Backported to 10.3.x as this is docs only.

  • alexpott committed 372e818d on 10.3.x 
    Issue #3450567 by kalpanajaiswal, joachim: GenerateTheme::__construct()...

  • alexpott committed 1723897e on 10.4.x 
    Issue #3450567 by kalpanajaiswal, joachim: GenerateTheme::__construct()...

  • alexpott committed 18daefd7 on 11.0.x 
    Issue #3450567 by kalpanajaiswal, joachim: GenerateTheme::__construct()...

  • alexpott committed 55e32b31 on 11.x 
    Issue #3450567 by kalpanajaiswal, joachim: GenerateTheme::__construct()...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.