This will spark discussion about how to do a formatter for image fields, I'm sure.

Issue fork custom_elements-3449309

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderik created an issue. See original summary.

roderik changed the visibility of the branch 3449309-convert-gallery-processor to hidden.

roderik changed the visibility of the branch 3449309-convert-gallery-processor to active.

roderik opened merge request !69

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Needs review

This MR in principle is only a single commit at the moment (the last one; link does not show my comment).

In practice it includes https://git.drupalcode.org/project/custom_elements/-/merge_requests/65 == #3448384: Replace twitter, video and image processors ; I can rebase it after that is reviewed.

(Or I can just push the last commit onto MR 65 if you want to not review that one standalone.)

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

as discussed we want to move this to a separate formater first

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs work » Needs review

  • fago committed fbc993b3 on 3.x authored by roderik 
    Issue #3449309 by roderik: Add formatter for file/image fields and...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

thx, looks great, merged!

I only had one comment, which could be added in a small follow-up PR if you agree.

Else, I'd suggest to add another small follow-up for introducing a new config option into the field/image formatter if the reference points to an image: An image-style drop-down.

That would be handy for media-references pointing to media-iamges as well, but I guess this should be its own follow-up.

Setting to needs-work for reading my comment and deciding how to continue!

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs work » Fixed
Related issues: +#3455426: Iterate on formatter code; add LinkCeFieldFormatter

Thanks! I added this feedback into #3455426: Iterate on formatter code; add LinkCeFieldFormatter with some other points for which I have code. (I think grouping some formatter specific changes in one issue is fine.)

Will work on that soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.