Subtask of #3443366: Convert thunder processors to config; fix/add formatter(s), for clarity.

Issue fork custom_elements-3447677

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderik created an issue. See original summary.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes

roderik opened merge request !63

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

commented, please re-check

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs work » Needs review

Done. I found no looping-over-$field_item->getValue() in the codebase, so needed to check a bit. I am not doing a check for "Primitive" anymore (that I took over from DefaultFieldItemProcessor, but I'm not attached to it. Immediately we also have an extra "options" property in the link.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Title: Fix 'raw' formatter, replace 'text' thunder processors » Replace 'text' thunder processors

Went with your suggestion "always only apply the values of the first field-item"; it makes things a lot more simple.

No need for the "force_single_value" option now (which I only needed here; I'll reuse that as needed, later) -- no need to extend the raw formatter.

  • fago committed 55053ddb on 3.x authored by roderik 
    Issue #3447677 by roderik: Remove thunder processors without...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Thx! :-) merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.