Problem/Motivation

Now that PHPUnit 10 is in, it's about time to be fully compatible with D11

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Token Unit Tests.png233.67 KBvishalkhode

Issue fork token-3445829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

Berdir opened merge request !75

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

deepakkm made their first commit to this issue’s fork.

vishalkhode’s picture

vishalkhode commented
StatusFileSize
new Token Unit Tests.png233.67 KB

Ran all PHPUnit tests on Drupal 11 and confirm all tests are passing:
PHPunit tests for Token module

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

@Berdir can we merge MR!75? CI is passing now and we can file a separate issues for deprecations in phpunit for D11 and other phpcs and phpstan issues.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs review

D11 tests are not passing yet.

The previous major was there on purpose, see #3447089: Disable previous major testing with D9 so that modules can prepare for D11.0 but it looks like it isn't going to happen like I'd prefer so, so maybe I'll leave it out here for now.

  • Berdir committed 381ba02f on 8.x-1.x 
    Issue #3445829 by Berdir, ankitv18, deepakkm: Drupal 11 compatibility
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Added the disabled deprecations variable until #3400979: Is SYMFONY_DEPRECATIONS_HELPER: weak correct for contrib deprecation testing needs? is resolved as a temporary workaround. Merging this.

@vishalkhode: Please do not include screenshots of executed tests (just like you should include screenshots of applying patches), that's considered trying to game the credits system and a waste of disk space on drupal.org

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vishalkhode’s picture

vishalkhode commented

@berdir: I understand your point. To clarify, If I had simply moved the ticket forward, it could have raised questions about how it was verified given that the Drupal CI was not working, so I've added comment with screenshots, The screenshot/comment was not intended to gain credit but to confirm that Drupal 11 compatibility changes verified in local by running PHPUnit tests. This was necessary as the Drupal CI was not functioning correctly and was throwing some errors. See this: https://git.drupalcode.org/issue/token-3445829/-/jobs/1591554.

@vishalkhode: Please do not include screenshots of executed tests (just like you should include screenshots of applying patches), that's considered trying to game the credits system and a waste of disk space on drupal.org