Problem/Motivation

According to guidelines by GSIS, when the authorization process is complete, the user should be logged-out from GSIS and then continue using Drupal.

Proposed resolution

The main Controller of this module should contain a separate logoutUrl property; there we are going to store the URL provided by GSIS.
Upon successful login, the user should be redirected to it and then redirected back to Drupal.

Remaining tasks

Implement this change.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 logout_user_from_gsis_after_drupal_login-3444301-8.patch2.82 KBvensires

Issue fork gsislogin-3444301

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vensires created an issue. See original summary.

vensires opened merge request !5

vensires’s picture

vensires
Location Greece
commented
Status: Active » Needs review
pappis’s picture

pappis
Primary language Greek
Location Greece
commented

I had to add

use Drupal\Core\Url;

to src/Controller/GsisLoginController.php

and then it worked.

vensires’s picture

vensires
Location Greece
commented
Status: Needs review » Needs work

@pappis could you be kind enough of updating the MR with your fix? :)

vensires’s picture

vensires
Location Greece
commented
Version: 2.0.x-dev » 2.1.x-dev
vensires’s picture

vensires
Location Greece
commented
Status: Needs work » Needs review

I have updated the MR with the latest fixes and rebased on top of 2.1.x.

Someone has to review this though.

vensires’s picture

vensires
Location Greece
commented
Status: Needs review » Fixed
StatusFileSize
new logout_user_from_gsis_after_drupal_login-3444301-8.patch2.82 KB

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.