Problem/Motivation

When navigating to a new page, the navigation toggle button is first rendered on closed position which leads to flickering. Ideally we could render the toggle initially in the correct position.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
CleanShot 2024-04-27 at 10.12.57.gif440.54 KBlauriii

Issue fork drupal-3443866

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

finnsky’s picture

finnsky commented

it should use transitions enabled after full load.
we have special attribute for this:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navig...

markusVJH made their first commit to this issue’s fork.

finnsky opened merge request !7791

finnsky’s picture

finnsky commented

I've added a bit deeper fix. We need to pause all transitions until scripts loaded.

finnsky’s picture

finnsky commented
Status: Active » Needs review
markusvjh’s picture

markusvjh commented
Status: Needs review » Reviewed & tested by the community

Great work. Tested, and the toggle button no longer flickers with the spin-around. I do get a slight flicker with a dash '-' showing up above the toggle button and next to shortcuts, but that could be a separate issue.

finnsky’s picture

finnsky commented

RE #7 Yes we have this ticket about shortcuts menu. You are right.

  • nod_ committed 20d5c8ad on 11.x 
    Issue #3443866 by finnsky, markusVJH: The toggle button flickers on page...

  • nod_ committed c668d7ec on 10.3.x 
    Issue #3443866 by finnsky, markusVJH: The toggle button flickers on page...

nod_ closed merge request !7791

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 20d5c8a and pushed to 11.x. Thanks!

  • nod_ committed 20d5c8ad on 11.0.x 
    Issue #3443866 by finnsky, markusVJH: The toggle button flickers on page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.