TypeError: Unsupported operand types: string + int in Drupal\smart_date\Plugin\migrate\process\ParseDates->transform()

Casting the $k is definitely a good place to start. It does seem like the code is expecting numeric keys but your data has some strings, so it's possible other issues will arise, but it's worth a try.

Great, thanks for the follow-up. Is this something that should be documented?

I've run into this same issue with a D7 date_repeat field, including getting the follow-up error 'field_smart_date_end_value' cannot be null. While trying to handle that, I came to a different conclusion.

The migration plugin is written to handle all the field values for the migrating row at once, but the migration system was passing values one by one. That meant that, rather than being a field deltas, $k was value, value2, or rrule. After casting $k as (int), the key the plugin was trying to access for the end value wasn't present - it was that very key that had been casted.

The solution in MR!117 was adding the migration plugin annotation handle_multiples, which tells the migration system to pass in all the row's field values at once. That's the input the plugin expects, and it resolved all the errors I encountered. All the instances of my repeating dates were created correctly.

Any UNTIL date of the rrule isn't being converted from D7 date format, but that's a separate issue.

Interesting! It does seem like this does indeed align with how the class was written, and it seems like a "low risk" solution, but I would love to get some additional community feedback on this one before we commit the change.

I ran into this problem with the following migration structure:

  # Date range.
  field_date:
    -
      source: field_event_instance_date
      plugin: parse_dates    

This is from a D10 site to a new D10 site - the old site used a core date field, the new site is Smart Date. MR 117 resolved the problem for me.

Thanks for everyone's contribution here. I have merged the annotation change.