Problem/Motivation

From https://git.drupalcode.org/project/webform_eloqua/-/jobs/1423413

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/WebformHandler/WebformEloquaHandler.php                    
 ------ ---------------------------------------------------------------------- 
  291    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  387    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 2 errors  

Steps to reproduce

Run Gitlab CI

Proposed resolution

Use dependency injection

Remaining tasks

  1. Update the code
  2. Test manually

User interface changes

None

API changes

None

Data model changes

None

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

PapaGrande created an issue. See original summary.

aaron.ferris made their first commit to this issue’s fork.

aaron.ferris’s picture

Status: Active » Needs review
papagrande’s picture

Status: Needs review » Reviewed & tested by the community

This module could really use automated functional tests, but I manually tested and reviewed the code. Thanks, @aaron.ferris.

papagrande’s picture

Status: Reviewed & tested by the community » Fixed
aaron.ferris’s picture

No problem!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.