Problem/Motivation
From https://git.drupalcode.org/project/webform_eloqua/-/jobs/1423413
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
------ ----------------------------------------------------------------------
Line src/Plugin/WebformHandler/WebformEloquaHandler.php
------ ----------------------------------------------------------------------
291 \Drupal calls should be avoided in classes, use dependency injection
instead
387 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------
[ERROR] Found 2 errors Steps to reproduce
Run Gitlab CI
Proposed resolution
Use dependency injection
Remaining tasks
- Update the code
- Test manually
User interface changes
None
API changes
None
Data model changes
None
Issue fork webform_eloqua-3443340
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
aaron.ferris commentedComment #5
papagrandeThis module could really use automated functional tests, but I manually tested and reviewed the code. Thanks, @aaron.ferris.
Comment #7
papagrandeComment #8
aaron.ferris commentedNo problem!