Need to add package.json file and any automation tools like Gulpjs in the theme.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ravi kant created an issue. See original summary.

adarshv made their first commit to this issue’s fork.

adarshv’s picture

Status: Active » Needs review

I have added package.json and gulpjs.

ravi kant’s picture

Status: Needs review » Needs work

@adarshv
I did not find changes.
I think you didnot commit changes or you did not attach patch.

adarshv’s picture

Status: Needs work » Needs review

ravi kant changed the visibility of the branch 1.0.x to hidden.

ravi kant’s picture

you had added changes directly in main branch So i have moved changes in this branch and created MR !36

ravi kant’s picture

@ Maintainers
Can you address this ticket?

sourojeetpaul’s picture

Assigned: Unassigned » sourojeetpaul
Status: Needs review » Needs work

Hello there,
Thanks for creating this issue, even I thought of implementing a build tool to provide a more robust solution in terms of SCSS compilation, while working on other issues of the theme.
While reviewing the MR I found a lot of scopes which can be improved and quite a lot of functionality can be introduced withing the gulpfile itself to make the live of the developers a bit more easy, as in we can add lint tasks for CSS and JS, autoprefixing with vendor prefixes to make it compatible with cross browsers, adding unit conversion to be able to use for relative units rather than defining static units, which might introduce some styling issue in future for responsive design. Also adding PostCSS processing will be great as in it provides a lot of new functionalities which are still in technical preview and gets to use them in a progressively enhanced manner.
Hence moving it to NW as of now, and I'd love to address the same!

sourojeetpaul’s picture

Assigned: sourojeetpaul » Unassigned
Status: Needs work » Needs review
Issue tags: +Needs subsystem maintainer review

Hi,
I've updated the gulpfile accordingly as I've mentioned on my previous comment. Pls have a look at it, would love to see it get merged :)

sourojeetpaul’s picture

I've created a child issue to incorporate the stylelint and eslint config, which will make the linting tasks of the gulp file work as expected.
Link to the child issue:
https://www.drupal.org/project/school_theme/issues/3460216

sourabhsisodia_’s picture

Tested MR !36 , the gulp file looks good and has all the required functonalities for scss compilation . Stylelint and eslint also working properly with MR !36.
RTBC++

sourabhsisodia_’s picture

Status: Needs review » Reviewed & tested by the community