Reviewed & tested by the community
Project:
School Theme
Version:
3.0.0
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Apr 2024 at 05:43 UTC
Updated:
14 Aug 2024 at 12:22 UTC
Jump to comment: Most recent
Comments
Comment #3
adarshv commentedI have added package.json and gulpjs.
Comment #4
ravi kant commented@adarshv
I did not find changes.
I think you didnot commit changes or you did not attach patch.
Comment #5
adarshv commentedHello @ravi kant,
please check " https://git.drupalcode.org/issue/school_theme-3443060/-/compare/1.0.x......"
Comment #8
ravi kant commentedyou had added changes directly in main branch So i have moved changes in this branch and created MR !36
Comment #9
ravi kant commented@ Maintainers
Can you address this ticket?
Comment #10
sourojeetpaul commentedHello there,
Thanks for creating this issue, even I thought of implementing a build tool to provide a more robust solution in terms of SCSS compilation, while working on other issues of the theme.
While reviewing the MR I found a lot of scopes which can be improved and quite a lot of functionality can be introduced withing the gulpfile itself to make the live of the developers a bit more easy, as in we can add lint tasks for CSS and JS, autoprefixing with vendor prefixes to make it compatible with cross browsers, adding unit conversion to be able to use for relative units rather than defining static units, which might introduce some styling issue in future for responsive design. Also adding PostCSS processing will be great as in it provides a lot of new functionalities which are still in technical preview and gets to use them in a progressively enhanced manner.
Hence moving it to NW as of now, and I'd love to address the same!
Comment #11
sourojeetpaul commentedHi,
I've updated the gulpfile accordingly as I've mentioned on my previous comment. Pls have a look at it, would love to see it get merged :)
Comment #12
sourojeetpaul commentedI've created a child issue to incorporate the stylelint and eslint config, which will make the linting tasks of the gulp file work as expected.
Link to the child issue:
https://www.drupal.org/project/school_theme/issues/3460216
Comment #13
sourabhsisodia_ commentedTested MR !36 , the gulp file looks good and has all the required functonalities for scss compilation . Stylelint and eslint also working properly with MR !36.
RTBC++
Comment #14
sourabhsisodia_ commented