Problem/Motivation

Updating the code base to meet the coding latest standards for phpcs / phpstan.

Steps to reproduce

Running the basic Drupal / DrupalPractice / SlevomatCodingStandard sniffs:

./vendor/bin/phpcbf -d memory_limit=4G --standard=phpcs.xml docroot/modules/contrib/pdf_metadata
./vendor/bin/phpcs -d memory_limit=4G --standard=phpcs.xml docroot/modules/contrib/pdf_metadata
./vendor/bin/phpstan analyse --memory-limit=4G docroot/modules/contrib/pdf_metadata

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pdf_metadata-3442133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

j-barnes created an issue. See original summary.

j-barnes’s picture

j-barnes commented
Issue summary: View changes

j-barnes opened merge request !8

j-barnes’s picture

j-barnes commented
j-barnes’s picture

j-barnes commented
Status: Active » Needs review
sunny-lee’s picture

sunny-lee commented
Status: Needs review » Reviewed & tested by the community

Looks good, tested on several nodes and media entities. Pdf metadata when enabled on media and nodes are correctly adding the metadata to the pdfs following settings. Tried this on newly created ones as well as editing older ones and worked on several different nodes and media entities.

  • j-barnes committed 59ba1fd1 on 1.0.x 
    Issue #3442133 by j-barnes: Coding standards cleanup
j-barnes’s picture

j-barnes commented

@sunny-lee - thanks for testing this out!

j-barnes’s picture

j-barnes commented
j-barnes’s picture

j-barnes commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.