CommentFileSizeAuthor
#5 description-change_3441728_2.patch15.25 KBjeroenvanoers
#3 description-change_3441728_1.patch14.19 KBjeroenvanoers

Issue fork message_banner-3441728

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jeroenvanoers created an issue. See original summary.

jeroenvanoers’s picture

jeroenvanoers commented
Issue summary: View changes

Select input to allow user to change the element the message banner gets appended to.

jeroenvanoers’s picture

jeroenvanoers commented
Assigned: jeroenvanoers » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new description-change_3441728_1.patch14.19 KB

mitthukumawat made their first commit to this issue’s fork.

jeroenvanoers’s picture

jeroenvanoers commented
Issue summary: View changes
StatusFileSize
new description-change_3441728_2.patch15.25 KB

mitthukumawat opened merge request !6

mitthukumawat’s picture

mitthukumawat commented
Status: Needs review » Reviewed & tested by the community

Above patch worked fine, still there was one issue in javascript.
The banner_attach setting was not referred to the javascript from hook_page_attachments. I have added and created a MR for merge.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Version: 2.0.0 » 3.0.x-dev
Assigned: Unassigned » sophie.sk
Status: Reviewed & tested by the community » Needs work

There are a lot of code style changes in the patch/merge request that shouldn't be there, and the JavaScript is unnecessarily duplicated. I'll reroll this against 3.0.x and fix these issues before merging.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Status: Needs work » Fixed

Done:

  • Field hadn't been added to settings form. Added an option to enable/disable override and set the default to 'body'.
  • Updated the JavaScript to avoid unnecessary duplication of code.
  • Added update hook to install the new settings.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • sophie.sk committed cd86072b on 3.0.x 
    feat: #3441728 Allow user to select to attach the banner to body or...

sophie.sk closed merge request !6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.