Problem/Motivation

Replace jQuery usage with vanilla js.

jQuery will be (hopefully) removed from core at some point. Our needed js is simple enough to be just vanilla js and avoid an extra dependency.

Proposed resolution

Replace jQuery usage with vanilla js.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork content_lock-3441684

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

idebr’s picture

idebr commented
Version: 8.x-2.x-dev » 3.x-dev

idebr opened merge request !95

alexpott made their first commit to this issue’s fork.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs work

We should addd some test coverage of the settings form to ensure this is all working. There's no test coverage of this JS atm.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Needs tests

A recent change added tests/src/FunctionalJavascript/ContentLockSettingsFormTest.php so this issue can easily add tests.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests

  • alexpott committed 0ef2faca on 3.x 
    task: #3441684 Replace jQuery usage with vanilla js

By: idebr
By:...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.