Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
render system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Apr 2024 at 02:29 UTC
Updated:
18 May 2024 at 08:19 UTC
Jump to comment: Most recent
Comments
Comment #3
quietone commentedComment #5
binoli lalani commentedComment #6
smustgrave commentedSearching for deprecated and 11.0
Appears to be another instances in HtmlResponseAttachmentsProcessor
Comment #7
binoli lalani commentedComment #8
smustgrave commentedLeft some comments.
Comment #10
binoli lalani commentedHello,
Thank you for reviewing the code. I have updated the code as per the comment on MR. Please review.
Thank you!
Comment #11
longwaveThe UrlGenerator tests should not be removed here, they are being done in #3425294: Remove deprecations for UrlGenerator methods
Comment #12
binoli lalani commentedHello,
I have reverted UrlGenerator code. Please review.
Thank you!
Comment #13
smustgrave commentedBelieve the deprecation tests are still there.
Comment #14
smustgrave commentedFixed up the MR, all green.
Comment #15
mikelutzLooks like all feedback has been addressed here, The removal looks good to me as well.
Comment #16
longwaveNeeds rebase, added some comments about property promotion, and this can be removed too:
Comment #17
smustgrave commentedAddressed feedback.
Comment #18
mikelutzUgh, I missed those, thanks. Feedback addressed. Back to rtbc
Comment #19
catchCouple more questions on the MR.
Comment #20
smustgrave commentedAddress feedback.
Comment #21
catchStill one remaining I think.
Comment #23
andypostHope now it ready
Comment #24
catchThat looks great now.
Comment #25
longwaveThere is still one error around the renderer config.
Comment #26
andypostApplied suggestion - it means there's no test for debug(
Comment #27
smustgrave commentedThat’s my bad. Got too eager with promotion
Comment #28
alexpottCommitted d60d2ce and pushed to 11.x. Thanks!
Comment #30
andypostplease close MR