We have failing tests in #3438895: Add the new Navigation to core as an Experimental module due to missing dependency system.menu.admin

ModuleConfigureRouteTest installs system module, but it does not installs system's config as part of setup(). When installing navigation as part of testModuleConfigureRoutes, dependency is missing.

To avoid this failing test and some other possible edge case errors, navigation.navigation_block.administration_menu should be moved to config/optional folder. This ensures that navigation block will be created if only the dependencies are already there.

Given that system configuration is there for core default profiles, this change will be transparent for them.

Issue fork navigation-3440982

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !247

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Move to NR

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks great! Nice catch.

  • m4olivei committed 3b1f7568 on 1.x authored by plopesc 
    Issue #3440982 by plopesc, m4olivei: Move navigation.navigation_block....
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Merged to 1.x 🎉. Thanks.

plopesc opened merge request !248

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Fixed » Needs review

New MR adding required missing dependencies in default config

  • m4olivei committed fc05aea4 on 1.x authored by plopesc 
    Issue #3440982 by plopesc, m4olivei: Move navigation.navigation_block....
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks good. I've merged it. Will update core inclusion MR and then if we get a green result, we'll mark this issue as fixed.

plopesc opened merge request !251

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs review

@m4olivei

There were some unrelated test fails due to #3437620: [Meta] Fix all tests that rely on UID1's super user behavior. Worked on them here to avoid creating a new issue.

Fixed them, I hope we don't have more unexpected conflicts here.

  • m4olivei committed 88169e59 on 1.x authored by plopesc 
    Issue #3440982 by plopesc, m4olivei: Move navigation.navigation_block....
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Tests passing and Tugboat looks fine. Merging and will update core MR.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

The core inclusion MR is now green! Thanks for chasing all of these down @plopesc!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.