The project needs a README file.

Issue fork contact_formatter-3440856

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thejimbirch created an issue. See original summary.

mohd sahzad’s picture

mohd sahzad commented
Assigned: Unassigned » mohd sahzad

Mohd Sahzad opened merge request !5

mohd sahzad’s picture

mohd sahzad commented
Assigned: mohd sahzad » Unassigned
Status: Active » Needs review
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work

Hi Mohd Sahzad

I reviewed your MR!5 and it seems the text isn't wrapped within around 80 cols. Since there are no recommended modules you can remove that section, hence it's not required as per the README.md template. Remove the contact in the Requirements sections since it's a Drupal core module.

Thanks,
Ken.

Diwakar07 made their first commit to this issue’s fork.

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review

I have fixed the issues as stated above by @kenyoOwen .
Please review.

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Needs work

In the Gitlab CI, the cspell job is now failing. We need to add the words that are failing as exceptions to the ci yml file.

Check out my other projects for examples.

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review

Thanks for the feedback @thejimbirch.
I have added the words that were failing as exceptions to the ci yml file.
Please review.

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.